-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update temurin8 Cask for jdk8u422-b05.1 point release re-build #180691
Update temurin8 Cask for jdk8u422-b05.1 point release re-build #180691
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Note, I have no idea what these two checkboxes mean? I am guessing the PR template could do with a fuller explanation of what a " is the token of the cask" is?
How does running those commands from my Mac relate to this PR?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @andrew-m-leonard!
To answer your questions, the cask token refers to its identifier, temurin@8
(see documentation).
The commands brew audit --cask --online <cask>
and brew style --fix <cask>
allow you to fix any outstanding issues before submitting the PR. brew audit
looks for a corresponding file in your installed taps (refer to our documentation on pull requests for more information).
As for the PR, I left a few suggestions below that would not require us to revert the changes on the next release.
Co-authored-by: Klaus Hipp <[email protected]>
Co-authored-by: Klaus Hipp <[email protected]>
Co-authored-by: Klaus Hipp <[email protected]>
Co-authored-by: Klaus Hipp <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Thank you @khipp I have included your suggestions, which makes it future proof, thank you |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.